Repository navigation
fix(stake): gasless deposit follow-ups before the flag goes on - #1568
Draft
DealAppSeo wants to merge 1 commit into
Draft
DealAppSeo wants to merge 1 commit into
DealAppSeo wants to merge 1 commit into
Conversation
- A relay that fails re-reads authorizationState: used (or canceled) answers 202 authorization_used_elsewhere, an unreadable state answers 202 send_not_checked, and only an unused one answers 502 "no USDC moved". A signed authorization can be submitted by anyone and pays the escrow, so a revert can mean the USDC did move. - Refuse with 503 wrong_network unless NETWORK resolves to Base Sepolia: verifyEip3009Local takes the EIP-712 chainId from NETWORK while the escrow sends only on 84532. - The route's catch-all answers a fixed message; the error text goes to the log. - The global 4/min admission budget can be griefed by four funded wallets: stated as a ponytail ceiling with the upgrade options (a decision, not decided here). - escrow-refunder.ts header names all three kinds of send on the escrow's one queue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner action
You merge (MAJOR: money path). This replaces #1564, which conflicted with
mainonce #1558 squash-merged. The guard blocks mergingmaininto a branch, so the same commit was cherry-picked ontomain(identical diff; 62/62 gasless and refunder tests pass on it). One decision is needed from you, item 4 below. Nothing here turns the flag on;GASLESS_DEPOSIT_MODEstaysoffby default.What this is
These are follow-ups for #1558 from an independent review, to fix before
GASLESS_DEPOSIT_MODE=on. #1558 is now merged as95d60b34; none of these is onmainyet.authorizationStatebefore it says "no USDC moved". Anyone can submit a signed authorization, and itstois the escrow, so a revert can mean another submitter used it and the USDC moved.authorization_used_elsewheresend_not_checkednot_sentverifyEip3009Localtakes the EIP-712chainIdfromNETWORK(getActiveNetwork), but the escrow sends only on Base Sepolia (84532). A server withNETWORKset to another chain, or to an unknown name, now refuses with 503wrong_networkbefore any chain read.src/routes/v1.ts) answers a fixed message. The error text goes to the log only. ethers puts the RPC URL, and any key in it, in its messages.ponytail:ceiling increateGaslessAdmissionand does not pick a fix. The options are to gate admission on something a rotated wallet cannot make for free (account age, a stake already held, a signed connect), or to charge the gas back from the deposit.escrow-refunder.tsheader now names all three kinds of send on the escrow's one queue: refunds, gasless relays and agent payouts.Evidence
E:\dev\reports\2026-11-16\r-loop\r3b.test-output-head.txt: 46/46 pass across the gasless, route, auth-bypass and relay suites.r3b.test-output-old-src.txt: the new tests against feat(stake): gasless owner deposit via USDC EIP-3009, default off (R3) #1558'sgasless-deposit.tsandv1.tsat64e02092. 4 fail: used-elsewhere, re-read-fails, wrong-network and route catch-all. The still-unused → 502 control passes on both.tsc --noEmitis clean.Not merged by Claude. Strix and the fenced Grok review have not run on this PR yet.
🤖 Generated with Claude Code